feat(general): Add the protect-check option that forces specific checks to always run#7489
Open
deese wants to merge 3 commits intobridgecrewio:mainfrom
Open
feat(general): Add the protect-check option that forces specific checks to always run#7489deese wants to merge 3 commits intobridgecrewio:mainfrom
deese wants to merge 3 commits intobridgecrewio:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if should_skip_check: | ||
| if is_protected: | ||
| result = True | ||
| logging.debug(f'protect_check override {check_id}: {result}') |
Author
There was a problem hiding this comment.
In previous lines the bc_check_id is logged. Is the check_id considered secret? (I can change it if needed).
deese
changed the title
deese
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new --protect-check option that forces specific checks to always run, even if they have been skipped via --skip-check, the YAML config file (skip-check:), or inline code comments (#checkov:skip=). This is useful in enforcement scenarios where certain security checks must never be suppressed by developers.
The option is available via:
Checklist:
Regarding the tests when I pull from the repo tons of tests are failing, so I'm not sure what to answer :). I've checked the ones I created and it works.