Skip to content

Gemfile: Use current Rails and sqlite3, complying with the spirit of the code comment#76

Closed
olleolleolle wants to merge 2 commits intobrunofacca:masterfrom
olleolleolle:default-to-current-rails-ga
Closed

Gemfile: Use current Rails and sqlite3, complying with the spirit of the code comment#76
olleolleolle wants to merge 2 commits intobrunofacca:masterfrom
olleolleolle:default-to-current-rails-ga

Conversation

@olleolleolle
Copy link
Copy Markdown
Contributor

This fails some output-related tests, but we will deal with those changes.

This fails some output-related tests, but we will deal with those changes.
@olleolleolle olleolleolle changed the title Use current Rails and sqlite3 Gemfile: Use current Rails and sqlite3, complying with the spirit of the code comment Nov 28, 2025
@brunofacca
Copy link
Copy Markdown
Owner

Thank you. Is this ready to merge?

@olleolleolle
Copy link
Copy Markdown
Contributor Author

@brunofacca No, sadly not, it's a little sad about Gemfile.lock details.

@olleolleolle olleolleolle marked this pull request as draft December 1, 2025 15:23
@brunofacca
Copy link
Copy Markdown
Owner

Sorry, but can you please elaborate?

@olleolleolle
Copy link
Copy Markdown
Contributor Author

  1. The build has fail-fast, so we don’t currently see all the builds.
  2. The ruby-head build fails like this:
The following platform specific gems are getting installed, yet the lockfile includes only their generic ruby version:
 * sqlite3-2.8.0-x86_64-linux-gnu
 * nokogiri-1.18.10-x86_64-linux-gnu
Please run `bundle lock --normalize-platforms` and commit the resulting lockfile.
Alternatively, you may run `bundle lock --add-platform <list-of-platforms-that-you-want-to-support>`
nokogiri-1.18.10-x86_64-linux-gnu requires ruby version < 3.5.dev, >= 3.1, which
is incompatible with the current version, 4.0.0.dev

So, platforms fixing. And perhaps setting the fail-fast: false on the strategy.

@brunofacca
Copy link
Copy Markdown
Owner

Hey. Sorry, I was away for a while.
Thank you for the explanation. Do you plan on doing any more work on this PR or should we close it?

@olleolleolle
Copy link
Copy Markdown
Contributor Author

Ah, thank you, this has been superseded by #79. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants