fix test suite and CI#89
Open
eqladios wants to merge 10 commits into
Open
Conversation
…uby 3.1+, ensuring compatibility with newer versions.
- these gems will no longer be part of the default gems starting from Ruby 3.5.0
- this is based on the gemspec created by the gem generator of bundle 2.7.2
- the missing array of comment objects, original yaml listed comments as a single object
- match CI test matrix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi everyone 👋 great job on this gem!
I've been trying to add some support for non-activerecord setups #88. However, the CI was failing due to errors in the tests and in the tests against the starter_repo, this PR fixes both the test suite and modernize and fixes the CI
Summary
Drop support for Ruby 2.6: original gemspec defines Ruby >= 2.6, However, some parts of the code is using arguments forwarding which is introduced in 2.7
Update gemspec to officially support Ruby 2.7+ and Rails 6+ (matching the CI matrix and passing), had to remove some usages of endless methods that was introduced at 3 (we can revert this and define 3 as minimum in gemspec)
Ruby 3.5 readiness: Add ostruct, bigdecimal, and logger as runtime dependencies since these stop shipping as default gems starting in Ruby 3.5.0.
Rails/ActiveRecord 8 compatibility: Update test setup to accommodate the new enum declaration style in AR 8.
SQLite3 constraint: Pin SQLite3 in the Gemfile to versions compatible with Rails 7.1+ / Ruby 3.1+. (failing original tests)
Cleanup & packaging: Exclude Gemfile and standard.yml from gem builds.
Fixtures: Fix YAML fixture shape (comments should be an array) and update ratings Jbuilder so ratings yield the correct comments array. (failing original tests)
Fix CI test against starter_repo: starter_repo removed the bin that this repo used in CI to test it, used the test stage in the starter_repo, this can be cleaner if the test stage in the starter repo allows injecting a gem before test. (failing original tests)
CI refresh: Bump GitHub Actions, enable Corepack/Yarn, broaden the Ruby/Rails matrix