fix: xonsh: Refactor space appending logic in action.go#1208
Merged
rsteube merged 1 commit intocarapace-sh:masterfrom Apr 26, 2026
Merged
fix: xonsh: Refactor space appending logic in action.go#1208rsteube merged 1 commit intocarapace-sh:masterfrom
rsteube merged 1 commit intocarapace-sh:masterfrom
Conversation
rsteube
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I've got the issue request from xonsh shell user but I see that the issue is on carapace side.
Before
After
Fix
Decide whether a trailing space is wanted BEFORE wrapping the value in quotes. Nospace is a SuffixMatcher and inspects the last rune of the value (e.g. "/" for directories, "=" for flags expecting a value). If we ran this check after quoting, the value would end with "'" and the match would always fail, causing a trailing space to be appended for paths like "foo bar/" -- the cursor would land after the space and tab completion of the next path part would be impossible.