fix: use fmt.Sprintln for correct newline handling in Println#1619
Open
ManManavadaria wants to merge 1 commit intocharmbracelet:mainfrom
Open
fix: use fmt.Sprintln for correct newline handling in Println#1619ManManavadaria wants to merge 1 commit intocharmbracelet:mainfrom
ManManavadaria wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1619 +/- ##
=======================================
Coverage 56.09% 56.09%
=======================================
Files 25 25
Lines 1287 1287
=======================================
Hits 722 722
Misses 481 481
Partials 84 84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
I noticed that the build-examples/build/govulncheck CI job in build.yml is failing with vulnerability GO-2025-3956. This happens because it uses an older Go version that has a vulnerability in the standard library. I believe this will no longer appear once the Go version is updated. The build failure in build-examples is an actual issue in the code, which I’ve already fixed in PR #1620 . I’d really appreciate it if you could review the PR and provide feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both the renderer and tea implement
Println()that takes args and should behave likefmt.Println. The current implementation usesfmt.Sprint, which does not handle newlines correctly. This change switches tofmt.Sprintlnso newlines are handled as expected.Fixes #1613
CONTRIBUTING.md.