Draft
Conversation
Owner
|
@wizenink honestly this looks much cleaner than I expected, I think we could totally move forward with this |
Contributor
Author
|
Nice :) Will focus on having feature gates synced between rust and the C wrapper for now, and leave fetching trt redist automatically for the future |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add support for TensorRT to cudarc.
As TensorRT is a C++ only lib, bindgen automatic generation does not work here, so a cpp wrapper is created to flatten TensorRT into C code.
Right now, we are not downloading redist files from nvidia, that would be a big TODO.
Working ATM:
Implementation details:
Missing:
@chelsea0x3b maybe you can check it out and just check if the implementation logic is right or if maybe another path should be taken to implement this