Draft
Conversation
jmhobbs
added
minor
jmhobbs
force-pushed
the
jmhobbs/cap-4067-upgrade-storybook
branch
from
727eb78 to
29341eb
Compare
Contributor
|
📦 Package Size: 9504 KB |
jmhobbs
force-pushed
the
jmhobbs/cap-4067-upgrade-storybook
branch
from
29341eb to
052d8dd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1268 +/- ##
=======================================
Coverage 77.37% 77.37%
=======================================
Files 189 189
Lines 3624 3624
Branches 1089 1091 +2
=======================================
Hits 2804 2804
Misses 705 705
Partials 115 115 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmhobbs
force-pushed
the
jmhobbs/cap-4067-upgrade-storybook
branch
from
5ee565c to
783b3b1
Compare
On classic yarn builds we were getting an old+new version introduced which did not include types, breaking the DTS build.
Contributor
Author
|
The |
Work around for storybook/internal module.createRequire calls to load semver at runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Published PR as canary version:
16.2.0--canary.1268.24099759068.0✨ Test out this PR locally via:
npm install chromatic@16.2.0--canary.1268.24099759068.0 # or yarn add chromatic@16.2.0--canary.1268.24099759068.0