Skip to content

CI uses noble now, we can use the compiled bpm release#2724

Merged
aramprice merged 1 commit intomainfrom
use-compiled-bpm
May 5, 2026
Merged

CI uses noble now, we can use the compiled bpm release#2724
aramprice merged 1 commit intomainfrom
use-compiled-bpm

Conversation

@aramprice
Copy link
Copy Markdown
Member

This was originally put in place because the CI pipelines ran on ubuntu-jammy after the releases started being compiled for ubuntu-noble

@aramprice aramprice requested review from a team, a-hassanin, Copilot and ramonskie and removed request for a team May 2, 2026 01:21
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6396941f-92be-468a-a584-09f244a2469b

📥 Commits

Reviewing files that changed from the base of the PR and between b648677 and cab66cb.

📒 Files selected for processing (1)
  • ci/pipeline.yml
💤 Files with no reviewable changes (1)
  • ci/pipeline.yml

Walkthrough

The CI pipeline ci/pipeline.yml was modified: within the bats job’s deploy-director step the DEPLOY_ARGS list had the -o bosh-deployment/misc/source-releases/bpm.yml entry removed. No other DEPLOY_ARGS entries were changed. Lines changed: one removal.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete. It lacks required sections like testing details, release notes, breaking change status, and team tags specified in the template. Add missing sections: test results, release notes description, breaking change statement, and team/pair tags as specified in the description template.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically summarizes the main change: removing the bpm source release workaround now that CI uses noble.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch use-compiled-bpm

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Concourse pipeline to stop forcing BPM to be used as a source release now that the main CI path targets Ubuntu Noble, allowing use of a compiled BPM release during director deployment.

Changes:

  • Removed -o bosh-deployment/misc/source-releases/bpm.yml from the bats deploy args.
  • Removed -o bosh-deployment/misc/source-releases/bpm.yml from the bats-fips deploy args.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ci/pipeline.yml
@github-project-automation github-project-automation Bot moved this from Inbox to Pending Merge | Prioritized in Foundational Infrastructure Working Group May 2, 2026
@aramprice aramprice merged commit 035839a into main May 5, 2026
22 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Merge | Prioritized to Done in Foundational Infrastructure Working Group May 5, 2026
@aramprice aramprice deleted the use-compiled-bpm branch May 5, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants