test: add wait for render for the ohif-downstream#2672
Merged
wayfarer3130 merged 5 commits intomainfrom Apr 16, 2026
Merged
Conversation
bb3731e to
653481c
Compare
jbocce
reviewed
Apr 15, 2026
jbocce
reviewed
Apr 15, 2026
jbocce
reviewed
Apr 15, 2026
jbocce
requested changes
Apr 15, 2026
Collaborator
jbocce
left a comment
There was a problem hiding this comment.
I love this initiative. See my comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Viewports didn't have a good way to check if they were rendered/up to date, resulting in using waits instead of actively waiting for changes to complete in OHIF and CS3D playwright tests.
This test has no functional change, just adds detection for needs render/rendered state.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment