Skip to content

test: add wait for render for the ohif-downstream#2672

Merged
wayfarer3130 merged 5 commits intomainfrom
fix/downstream-ohif-integration
Apr 16, 2026
Merged

test: add wait for render for the ohif-downstream#2672
wayfarer3130 merged 5 commits intomainfrom
fix/downstream-ohif-integration

Conversation

@wayfarer3130
Copy link
Copy Markdown
Collaborator

@wayfarer3130 wayfarer3130 commented Mar 19, 2026

Context

Viewports didn't have a good way to check if they were rendered/up to date, resulting in using waits instead of actively waiting for changes to complete in OHIF and CS3D playwright tests.

This test has no functional change, just adds detection for needs render/rendered state.

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] "OS:
  • [] "Node version:
  • [] "Browser:

@wayfarer3130 wayfarer3130 changed the title fix: ohif-downstream integration [REPLACED] add build fixes and hooks to wait for render for the ohif-downstream Apr 6, 2026
@wayfarer3130 wayfarer3130 force-pushed the fix/downstream-ohif-integration branch from bb3731e to 653481c Compare April 14, 2026 20:57
@wayfarer3130 wayfarer3130 requested a review from jbocce April 14, 2026 20:59
@wayfarer3130 wayfarer3130 changed the title [REPLACED] add build fixes and hooks to wait for render for the ohif-downstream test: add wait for render for the ohif-downstream Apr 14, 2026
Comment thread packages/tools/src/utilities/segmentation/utilsForWorker.ts
Comment thread tests/utils/waitForViewportsRendered.ts Outdated
Comment thread tests/utils/waitForViewportsRendered.ts Outdated
Copy link
Copy Markdown
Collaborator

@jbocce jbocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this initiative. See my comments

Copy link
Copy Markdown
Collaborator

@jbocce jbocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the changes.

@wayfarer3130 wayfarer3130 merged commit 9bc6536 into main Apr 16, 2026
11 of 12 checks passed
@wayfarer3130 wayfarer3130 deleted the fix/downstream-ohif-integration branch April 16, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants