using voxelManager in SegmentSelectTool to fix Inside mode#2702
Open
theoc0702 wants to merge 1 commit intocornerstonejs:mainfrom
Open
using voxelManager in SegmentSelectTool to fix Inside mode#2702theoc0702 wants to merge 1 commit intocornerstonejs:mainfrom
theoc0702 wants to merge 1 commit intocornerstonejs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Currently, it is problematic to use the

SegmentSelectToolconfigured withSelectMode.Insidein integrated environments (like OHIF). When the tool attempts to evaluate the hovered segment, it can fail to read the underlying data appropriately, resulting in the following TypeError regardinggetNumberOfComponents:Changes & Results
getSegmentIndexAtWorldPoint(and associated utilities).imageDataevaluation withvoxelManager.imageData,utilities.transformWorldToIndex, andvoxelManager.getAtIJK().SelectMode.Insideconfiguration can now be used safely without throwing data evaluation errors.Testing
SegmentSelectToolwith{ mode: SegmentSelectTool.SelectMode.Inside }.Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment