fix(tools): sync flip state from source viewport to magnify viewport#2705
Merged
jbocce merged 2 commits intocornerstonejs:mainfrom Apr 21, 2026
Merged
Conversation
…nd AdvancedMagnifyTool MagnifyTool was not propagating flipHorizontal/flipVertical when creating the magnify viewport. AdvancedMagnifyTool was not passing flip state in _syncViewportsCameras, causing the magnify viewport to always render in the unflipped orientation regardless of the source viewport's flip state.
jbocce
approved these changes
Apr 21, 2026
Collaborator
jbocce
left a comment
jbocce
left a comment
There was a problem hiding this comment.
Looks great. I also tested this is OHIF.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This fixes a bug in OHIF :
OHIF/Viewers#5646
When a viewport is flipped horizontally, the magnify tools render the image without applying the flip. This causes the magnified view to not match the source viewport.
Changes & Results
MagnifyTool: extractflipHorizontalandflipVerticalfromgetViewPresentation()and include them insetViewPresentation()on the magnify viewportAdvancedMagnifyTool: readflipHorizontalandflipVerticalfromsourceViewport.getCamera()and pass them tomagnifyViewport.setCamera()in_syncViewportsCameras()flip-orientation-after.mov
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment