Patch to allow calibration of un-calibrated 36-samples EvB data#243
Draft
Patch to allow calibration of un-calibrated 36-samples EvB data#243
Conversation
This just converts the waveforms to 40 samples
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
- Coverage 91.05% 90.96% -0.09%
==========================================
Files 25 25
Lines 2693 2702 +9
==========================================
+ Hits 2452 2458 +6
- Misses 241 244 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maxnoe
reviewed
Mar 13, 2026
| if self.data_stream is not None: | ||
| for c, fill_value in zip((array_event.r0, array_event.r1), | ||
| (self.data_stream.waveform_offset, 0)): | ||
| for tel_c in c.tel.values(): |
Member
There was a problem hiding this comment.
loop twice over the same thing here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just converts the waveforms to 40 samples before the calibration.
(R1, as usual, is later clipped back to 36)
Note, we hardly have any data (~30') taken like that... it is arguable whether this patch needs to be merged!
Just leave it here in case it is needed.