fix: prevent tooltips from being scrollable#162
Open
djanhjo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent tooltips from being scrollable, since they should be sized to whatever content they have. Also initialize with
height: 0to prevent initial load of empty scrollable space.Note
Low Risk
Small tooltip markup/CSS change with no auth, data, or API impact; height is still set by existing resize logic.
Overview
Tooltip iframes were showing scrollbars and reserving empty scrollable area before content sized them.
The tooltip template now sets
.gist-tooltip-frametoheight: 0untilresizeTooltipComponentapplies the content height (existing height transition unchanged), and addsscrolling="no"on the tooltip iframe so it does not scroll independently of the sized content.Reviewed by Cursor Bugbot for commit 9cc7790. Bugbot is set up for automated code reviews on this repo. Configure here.