fix(giscus): add missing attributes and allow local theme#1407
Closed
ReenigneArcher wants to merge 2 commits intodaattali:masterfrom
Closed
fix(giscus): add missing attributes and allow local theme#1407ReenigneArcher wants to merge 2 commits intodaattali:masterfrom
ReenigneArcher wants to merge 2 commits intodaattali:masterfrom
Conversation
ReenigneArcher
force-pushed
the
fix/giscus/add-missing-attributes
branch
from
fdc8c2a to
92a2e6b
Compare
49 tasks
ReenigneArcher
changed the title
ahmadwardat
reviewed
Apr 24, 2025
21 tasks
ReenigneArcher
force-pushed
the
fix/giscus/add-missing-attributes
branch
from
92a2e6b to
65ccb62
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
ReenigneArcher
force-pushed
the
fix/giscus/add-missing-attributes
branch
from
65ccb62 to
ce9ebfa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some missing giscus attributes. I assume these were not available when giscus was added originally.
Additionally, there is a logic change that allows a local css file for the giscus theme. I tried to test this locally and it requires CORS to be disabled, I am not sure how this would work on a GitHub hosted site, but in any event it allows to specify a theme like
/assets/css/giscus.cssor any local path that starts with/. Normally giscus will try to get any non full url theme from their own server/api.https://giscus.app/
Here is a screenshot of evidence of the a custom theme css working for giscus.
