Skip to content

1862 import pam time files#1884

Merged
nfahlgren merged 68 commits intov5.0from
1862-import-pam-time-files
Mar 15, 2026
Merged

1862 import pam time files#1884
nfahlgren merged 68 commits intov5.0from
1862-import-pam-time-files

Conversation

@kmurphy61
Copy link
Copy Markdown
Contributor

@kmurphy61 kmurphy61 commented Feb 26, 2026

Describe your changes
Update read_cropreporter.py to import PMT (PAM time) files from Phenovation software for quenching analysis. Documentation and tests have been updated.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
Issue 1862

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@kmurphy61 kmurphy61 force-pushed the 1862-import-pam-time-files branch from a58bcff to 246c322 Compare February 26, 2026 16:43
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Feb 26, 2026

DeepSource Code Review

We reviewed changes in ff465ec...c4ae8c8 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Mar 15, 2026 8:59p.m. Review ↗
Test coverage Mar 15, 2026 8:59p.m. Review ↗

Update for deepsource error, frame_nums is not needed in pmt import because they are all relabeled
@kmurphy61 kmurphy61 added the update Updates an existing feature/method label Feb 26, 2026
kmurphy61 and others added 12 commits March 2, 2026 13:54
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@nfahlgren nfahlgren requested a review from Copilot March 4, 2026 20:45
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread tests/plantcv/photosynthesis/test_read_cropreporter.py
Comment thread tests/plantcv/photosynthesis/test_read_cropreporter.py Outdated
Comment thread plantcv/plantcv/photosynthesis/read_cropreporter.py Outdated
Comment thread tests/plantcv/photosynthesis/conftest.py Outdated
@nfahlgren nfahlgren merged commit ca4ac9a into v5.0 Mar 15, 2026
1 of 5 checks passed
@nfahlgren nfahlgren deleted the 1862-import-pam-time-files branch March 15, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to review update Updates an existing feature/method

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants