Fix favicon fetching to check all icon links instead of just the first one

[Shocker]

Fix logic in download_icon(), got broken (most likely accidentally) in 27dc67f#diff-c0f730ed83eb02623c5c9bde35b0366115b8961fb596c27f98613140cba6d2a7L714 which caused the downloader to stop after first error

Also don't limit max checked icons to 5, allow all icons in the list

[BlackDex]

The reason we only select the first 5 items is because we do not want to try and download every icon a site has listed.
It could be 1 or 20, and calling a site 20 times might also trigger a block/ban even.

The 5 items from the list are already sorted in a most preferred item is at the top of the list.

Are there specific sites on which you experience issues?
Since, i have run a local script which compares icons between Vaultwarden, Bitwarden, Google and DuckDuckGo.
And there are just a few which do not work currently, but also a lot which Vaultwarden is able to fetch an icon where Bitwarden, Google or DuckDuckGo (Either one or more) is not.

[Shocker]

Regarding the 5 limit: I don't have any specific site with issues. To be honest it was just a weird seemingly undocumented line in the code which didn't make sense to have an arbitrary limit of 5.

What about the main issue being fixed with the PR?

[BlackDex]

Which main issue do you refer to?
Is it that if one item fails it stop and aborts?

[Shocker]

Which main issue do you refer to? Is it that if one item fails it stop and aborts?

Yes.