Add support for archiving items

[matt-aaron]

Adds support for archiving items: #6372

I'm new to the codebase, so let me know if I have missed anything. Happy to apply any feedback you may have. Thank you!

[stefan0xC]

@BlackDex I have not tested it (and I am not sure how stable this feature is yet) but could we not just enable this feature directly instead of adding a new feature flag that you have to opt in?

Also the feature flags we set have already been removed for a few releases, so they can be safely replaced in my opinion.

vaultwarden/src/api/core/mod.rs

Lines 208 to 212 in ba55191

	feature_states.insert("duo-redirect".to_string(), true);
	feature_states.insert("email-verification".to_string(), true);
	feature_states.insert("unauth-ui-refresh".to_string(), true);
	feature_states.insert("enable-pm-flight-recorder".to_string(), true);
	feature_states.insert("mobile-error-reporting".to_string(), true);

[matt-aaron]

With it being included in the 2026.2.1 release announcement, I think it'd be stable enough to enable directly

[matt-aaron]

I have enabled the flag directly and removed some of the older flags (keeping email-verification and mobile-error-reporting).

@BlackDex Let me know if this needs further adjustments

[qianlongzt]

I’m just wondering why we don’t simply add a field to the ciphers table.

https://github.com/bitwarden/server/blob/main/src/Sql/dbo/Vault/Tables/Cipher.sql#L16
ref: bitwarden/server#6578

[matt-aaron]

I’m just wondering why we don’t simply add a field to the ciphers table.

https://github.com/bitwarden/server/blob/main/src/Sql/dbo/Vault/Tables/Cipher.sql#L16 ref: bitwarden/server#6578

They originally did that, but later added the archives column to that table. This enables users the archives to be per-user instead of impacting other users within an org, for example.

[matt-aaron]

Refactored to properly support importing items that were archived

[dcelasun]

@BlackDex any further thoughts on this? Seems fairly straightforward and previous comments were addressed.

[BlackDex]

I need time to check and verify this, or @dani-garcia must have some time of course.
But I am busy with a lot of other stuff which needs attention, and for me, new feature are nice, especially this one, but they do come in a lower rank then some other items.

[BlackDex]

This is not needed when adding it as a default flag, since those can't be adjusted by users anyway.

[matt-aaron]

Ah, true. Removed

[BlackDex]

Looking at the migration sql's i think there are some joinable!() lines missing between the archives and users/ciphers tables. Without those Diesel doesn't treat those as joinable records during queries or might be unable to optimize the queries.

[matt-aaron]

Added the joinable!() lines and also included archives in the allow_tables_to_appear_in_same_query!() macro