This repository was archived by the owner on Dec 9, 2020. It is now read-only.
Fix filename extension of common include file for gruvbox-* themes#35
Open
SpotlightKid wants to merge 1 commit intodavatorium:masterfrom
Open
Fix filename extension of common include file for gruvbox-* themes#35SpotlightKid wants to merge 1 commit intodavatorium:masterfrom
SpotlightKid wants to merge 1 commit intodavatorium:masterfrom
Conversation
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
Collaborator
|
I think the 'inc' might be better, otherwise common file shows up in theme selector.. (I should fix this in rofi). |
Author
|
Yes, that's what happens with the globally installed But, as it is now, the gruvbox themes installed from this repo do not work at all, because the BTW, I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The common include file for the gruvbox-* was not installed, because it has an
.incextension instead of.rasi. Also, when including files, rofi always adds the.rasiextension, so I renamed the.incfile and fixed the includes in the themes using it.BTW, in the rofi distribution this is already fixed in the same way.