Skip to content
This repository was archived by the owner on Dec 9, 2020. It is now read-only.

Fix filename extension of common include file for gruvbox-* themes#35

Open
SpotlightKid wants to merge 1 commit intodavatorium:masterfrom
SpotlightKid:bugfix/gruvbox-common-include
Open

Fix filename extension of common include file for gruvbox-* themes#35
SpotlightKid wants to merge 1 commit intodavatorium:masterfrom
SpotlightKid:bugfix/gruvbox-common-include

Conversation

@SpotlightKid
Copy link
Copy Markdown

The common include file for the gruvbox-* was not installed, because it has an .inc extension instead of .rasi. Also, when including files, rofi always adds the .rasi extension, so I renamed the .inc file and fixed the includes in the themes using it.

BTW, in the rofi distribution this is already fixed in the same way.

Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
@DaveDavenport
Copy link
Copy Markdown
Collaborator

I think the 'inc' might be better, otherwise common file shows up in theme selector.. (I should fix this in rofi).

@SpotlightKid
Copy link
Copy Markdown
Author

Yes, that's what happens with the globally installed gruvbox-common.rasi file from the rofi distribution.

But, as it is now, the gruvbox themes installed from this repo do not work at all, because the .inc doesn't get installed, and even if it is, it will not be found.

BTW, I think rofi-theme-selector should filter out themes in the system themes directory, which are overwritten by a user theme with the same file name.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants