Merged
Conversation
gabolaev
force-pushed
the
custom-download-strategy
branch
from
f5b02a3 to
bf057f4
Compare
maxcleme
reviewed
Mar 4, 2026
| class GitHubPrivateRepositoryReleaseDownloadStrategy < AbstractFileDownloadStrategy | ||
| def initialize(url, name, version, **meta) | ||
| super | ||
| @github_token = ENV["HOMEBREW_GITHUB_API_TOKEN"] |
Member
There was a problem hiding this comment.
Can't we look at these two insteads? IMO these are far more common than HOMEBREW_GITHUB_API_TOKEN, right?
(I don't if || is the right way to do in ruby)
Suggested change
| @github_token = ENV["HOMEBREW_GITHUB_API_TOKEN"] | |
| @github_token = ENV["GH_TOKEN"] || ENV["GITHUB_TOKEN"] |
Member
Author
There was a problem hiding this comment.
Homebrew can only read HOMEBREW_.* env vars
gabolaev
force-pushed
the
custom-download-strategy
branch
21 times, most recently
from
c2845a9 to
80e8b9f
Compare
gabolaev
force-pushed
the
custom-download-strategy
branch
from
80e8b9f to
86702b1
Compare
maxcleme
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.