Add ESLint and Prettier as linter and formatter#74
Add ESLint and Prettier as linter and formatter#74JakubSchwenkbeck wants to merge 12 commits intomasterfrom
Conversation
JakubSchwenkbeck
requested review from
jiribenes and
timsueberkrueb
and removed request for
jiribenes
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "semi": true, | |||
| "trailingComma": "none", | |||
There was a problem hiding this comment.
I'm personally in favor of trailing commas as they reduce diffs.
| @@ -0,0 +1,48 @@ | |||
| /** | |||
|
Once you agree on the formatting changes, please squash the formatting changes (and those only) into a single commit and then use https://docs.github.com/en/repositories/working-with-files/using-files/viewing-and-understanding-files#ignore-commits-in-the-blame-view to ignore that reformatting commit in blame. |
| }, | ||
| rules: { | ||
| 'prettier/prettier': 'error', // Treat Prettier issues as ESLint errors | ||
| 'curly': 'warn', |
There was a problem hiding this comment.
I don't know what all of these are for, are these some defaults or did you deliberately change them?
There was a problem hiding this comment.
they are mostly taken from :
https://github.com/microsoft/vscode-extension-samples/blob/main/lsp-sample/eslint.config.mjs
|
I guess just start going from a clean branch seems the easiest:) |
|
closed via #75 |
3 participants
This PR introduces
npx eslint .ornpm run lintandnpm run lint:fixto lint or lint&fix all files at once)npm run formatandnpm run format:check)The CI performs
npm run lintandnpm run format:checkresolves #73