refactor: long-form docker-compose syntax with de-collisioned host ports#13
Open
omranjamal wants to merge 2 commits intoehfazrezwan:devfrom
Open
refactor: long-form docker-compose syntax with de-collisioned host ports#13omranjamal wants to merge 2 commits intoehfazrezwan:devfrom
omranjamal wants to merge 2 commits intoehfazrezwan:devfrom
Conversation
Merge dev into main
…orts - Convert ports to long-form (target/published/protocol) - Convert volumes to long-form (type/source/target) - Shift default host ports by +7 to avoid collisions with local services - Make all host ports overridable via env vars (NEO4J_HTTP_PORT, REDIS_PORT, etc.) - Remove redundant REDIS_URL and QDRANT_URL from .env.example (overridden by docker-compose environment block) - Comment out NEO4J_PASSWORD in .env.example (default already set in docker-compose) - Add .omc/ to .gitignore Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
ReviewChanges look good — long-form syntax, port de-collision, and env overrides are clean. No impact on inter-container communication, One note on Not a blocker — just a DX consideration. Also, can you retarget this PR to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target/published/protocol) and volume mounts to long-form (type/source/target) for clarity and extensibilityPort mapping
NEO4J_HTTP_PORTNEO4J_BOLT_PORTREDIS_PORTQDRANT_HTTP_PORTQDRANT_GRPC_PORTNEURALSCAPE_PORT.env.example cleanup
REDIS_URLandQDRANT_URL(overridden by docker-composeenvironmentblock; Pydantic picks up the runtime env vars at higher priority anyway)NEO4J_PASSWORD(already defaulted via${NEO4J_PASSWORD:-neuralscape}in docker-compose)Other
.omc/to.gitignoreVerification
No changes to container-internal ports, inter-container URLs, healthchecks,
config.pydefaults, or documentation.Test plan
docker compose config --quietpassesdocker compose up -dstarts all services on the new default ports.envwork as expected (e.g.REDIS_PORT=6379)🤖 Generated with Claude Code