Add MapEnumVariants transform and supporting test.#131
Open
inferiorhumanorgans wants to merge 1 commit intoembassy-rs:mainfrom
Open
Add MapEnumVariants transform and supporting test.#131inferiorhumanorgans wants to merge 1 commit intoembassy-rs:mainfrom
inferiorhumanorgans wants to merge 1 commit intoembassy-rs:mainfrom
Conversation
This is useful when an SVD contains enum variants with purely numeric identifiers as Renesas is prone to doing. It should/could potentially be extended to use regular expressions and merged with the existing `RenameEnumVariants` transform. However this is useful in cases where something akin to a `RegexSet` might be used, where `RenameEnumVariants` is more useful where a small number of variants need to be changed. This could potentially be merged with `AddEnumVariants` but the current behavior is to simply ignore variants that don't match. That allows a single transform to be applied to slightly different variations of an enum. This could potentially be merged with the `RenameFields` or more general `Rename` transform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful when an SVD contains enum variants with purely numeric identifiers as Renesas is prone to doing.
It should/could potentially be extended to use regular expressions and merged with the existing
RenameEnumVariantstransform. However this is useful in cases where something akin to aRegexSetmight be used, whereRenameEnumVariantsis more useful where a small number of variants need to be changed.This could potentially be merged with
AddEnumVariantsbut the current behavior is to simply ignore variants that don't match. That allows a single transform to be applied to slightly different variations of an enum.This could potentially be merged with the
RenameFieldsor more generalRenametransform.