Skip to content

[release-1.3] Bump go to 1.25.8#1158

Open
shuan1026 wants to merge 2 commits intoetcd-io:release-1.3from
shuan1026:bump-release1.3-go-v1.25.7
Open

[release-1.3] Bump go to 1.25.8#1158
shuan1026 wants to merge 2 commits intoetcd-io:release-1.3from
shuan1026:bump-release1.3-go-v1.25.7

Conversation

@shuan1026
Copy link
Copy Markdown
Contributor

@shuan1026 shuan1026 commented Mar 2, 2026

Ref: etcd-io/etcd#21364
Ref: etcd-io/etcd#21458

From https://go.dev/doc/devel/release#go1.25.0

go1.25.7 (released 2026-02-04) includes security fixes to the go command and the crypto/tls package, as well as bug fixes to the compiler and the crypto/x509 package.
go1.25.8 (released 2026-03-05) includes security fixes to the html/template, net/url, and os packages, as well as bug fixes to the go command, the compiler, and the os package. See the Go 1.25.8 milestone on our issue tracker for details.

@ahrtr
Copy link
Copy Markdown
Member

ahrtr commented Mar 2, 2026

/ok-to-test

@ivanvc
Copy link
Copy Markdown
Member

ivanvc commented Mar 3, 2026

Same for this one, it needs a #954 backport. That's what is making the workflows fail.

@ivanvc ivanvc mentioned this pull request Mar 4, 2026
18 tasks
@shuan1026 shuan1026 changed the title [release-1.3] Bump go to 1.25.7 [release-1.3] Bump go to 1.25.8 Mar 8, 2026
@shuan1026 shuan1026 force-pushed the bump-release1.3-go-v1.25.7 branch from 25dbfc8 to 59a1d76 Compare March 10, 2026 12:41
@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Elbehery, shuan1026

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment thread .github/workflows/tests.yaml Outdated
- linux-amd64-unit-test-4-cpu-race
runs-on: ubuntu-latest
env:
GOTOOLCHAIN: auto
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Apr 8, 2026

@shuan1026 are you still working on this? 1.25.9 is out. if you don't have time, please let us know. thanks

@shuan1026
Copy link
Copy Markdown
Contributor Author

@shuan1026 are you still working on this? 1.25.9 is out. if you don't have time, please let us know. thanks

Hi @fuweid, yes I'm still working on this, thanks for the heads-up

Here's a summary of what's been happening:

The original PRs #1157 (release-1.4) and #1158 (release-1.3) ran into a test-windows CI failure.

Two related PRs #1178 (release-1.4) and #1177 (release-1.3) were opened to bump golangci-lint to v2, which was trying to unblock the CI. The discussion in #1178 then led to #1181 on main, which introduced a dedicated lint CI job.

I've now backported the approach from #1181 into this PR (#1157) to fix the Windows CI issue — moving lint into a dedicated job with shell: bash and go-version-file to ensure the correct Go version is used on Windows runners. Also removed the gci formatter from .golangci.yaml as it was incorrectly flagging all files on Windows due to CRLF line endings.

I'll also update #1158 accordingly for release-1.3. And I can update both PRs to target Go 1.25.9 if that's preferred

I'm fairly new to contributing here, if there's anything I should do differently or if you have any suggestions, please don't hesitate to let me know. Thanks again for your help

Signed-off-by: Mark Tsai <111229657+shuan1026@users.noreply.github.com>
@shuan1026 shuan1026 force-pushed the bump-release1.3-go-v1.25.7 branch from b3ec781 to 861fdfb Compare April 18, 2026 02:05
@shuan1026 shuan1026 force-pushed the bump-release1.3-go-v1.25.7 branch from 861fdfb to f457e55 Compare April 18, 2026 02:14
Signed-off-by: Mark Tsai <111229657+shuan1026@users.noreply.github.com>
@shuan1026 shuan1026 force-pushed the bump-release1.3-go-v1.25.7 branch from f457e55 to af46bba Compare April 18, 2026 03:18
@shuan1026
Copy link
Copy Markdown
Contributor Author

After #1177 is merged into release-1.3, this PR only needs a rebase to pass CI.

  • [release-1.3] Bump golangcilint to v2 #1177 upgrades golangci-lint to v2, adds .golangci.yaml with appropriate suppressions (avoiding any changes to stable code), and disables linting on Windows to avoid the gofmt CRLF issue.
  • This PR adds the Go 1.25.8 bump and pins actions/checkout / actions/setup-go to full commit SHAs across tests.yaml, failpoint_test.yaml, and robustness_test.yaml (required by the etcd-io/bbolt action policy).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants