[release-1.3] Bump go to 1.25.8#1158
Conversation
|
/ok-to-test |
|
Same for this one, it needs a #954 backport. That's what is making the workflows fail. |
25dbfc8 to
59a1d76
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Elbehery, shuan1026 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| - linux-amd64-unit-test-4-cpu-race | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| GOTOOLCHAIN: auto |
There was a problem hiding this comment.
|
@shuan1026 are you still working on this? 1.25.9 is out. if you don't have time, please let us know. thanks |
Hi @fuweid, yes I'm still working on this, thanks for the heads-up Here's a summary of what's been happening: The original PRs #1157 (release-1.4) and #1158 (release-1.3) ran into a test-windows CI failure. Two related PRs #1178 (release-1.4) and #1177 (release-1.3) were opened to bump golangci-lint to v2, which was trying to unblock the CI. The discussion in #1178 then led to #1181 on main, which introduced a dedicated lint CI job. I've now backported the approach from #1181 into this PR (#1157) to fix the Windows CI issue — moving lint into a dedicated job with shell: bash and go-version-file to ensure the correct Go version is used on Windows runners. Also removed the gci formatter from .golangci.yaml as it was incorrectly flagging all files on Windows due to CRLF line endings. I'll also update #1158 accordingly for release-1.3. And I can update both PRs to target Go 1.25.9 if that's preferred I'm fairly new to contributing here, if there's anything I should do differently or if you have any suggestions, please don't hesitate to let me know. Thanks again for your help |
Signed-off-by: Mark Tsai <111229657+shuan1026@users.noreply.github.com>
b3ec781 to
861fdfb
Compare
861fdfb to
f457e55
Compare
Signed-off-by: Mark Tsai <111229657+shuan1026@users.noreply.github.com>
f457e55 to
af46bba
Compare
|
After #1177 is merged into release-1.3, this PR only needs a rebase to pass CI.
Thanks! |
Ref: etcd-io/etcd#21364
Ref: etcd-io/etcd#21458
From https://go.dev/doc/devel/release#go1.25.0