Skip to content

Refactor read pt. 2#21601

Merged
serathius merged 5 commits intoetcd-io:mainfrom
serathius:refactor-read2
Apr 15, 2026
Merged

Refactor read pt. 2#21601
serathius merged 5 commits intoetcd-io:mainfrom
serathius:refactor-read2

Conversation

@serathius
Copy link
Copy Markdown
Member

continuation of #21573

Moving read code into subpackage.

/cc @ahrtr @fuweid

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 95.18072% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.45%. Comparing base (f0c0ca0) to head (a060bdd).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
server/etcdserver/read/read.go 96.00% 2 Missing ⚠️
server/etcdserver/server.go 80.00% 0 Missing and 1 partial ⚠️
server/etcdserver/v3_server.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/interface.go 100.00% <100.00%> (ø)
server/etcdserver/metrics.go 82.60% <ø> (+1.35%) ⬆️
server/etcdserver/raft.go 87.30% <100.00%> (+0.13%) ⬆️
server/etcdserver/read/metrics.go 100.00% <100.00%> (ø)
server/etcdserver/read/util.go 100.00% <100.00%> (ø)
server/etcdserver/util.go 100.00% <ø> (ø)
server/etcdserver/server.go 83.32% <80.00%> (+0.89%) ⬆️
server/etcdserver/v3_server.go 72.11% <66.66%> (ø)
server/etcdserver/read/read.go 89.20% <96.00%> (ø)

... and 17 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21601      +/-   ##
==========================================
+ Coverage   68.37%   68.45%   +0.07%     
==========================================
  Files         429      432       +3     
  Lines       35391    35413      +22     
==========================================
+ Hits        24200    24243      +43     
+ Misses       9785     9771      -14     
+ Partials     1406     1399       -7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c0ca0...a060bdd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius
Copy link
Copy Markdown
Member Author

ping @ahrtr @fuweid

Comment thread server/etcdserver/read/read.go Outdated
Comment thread server/etcdserver/read/read.go Outdated
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Copy Markdown
Member Author

/retest

@serathius serathius merged commit a34734d into etcd-io:main Apr 15, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants