Skip to content

Add --keys-only option for mvcc range#21612

Open
nwnt wants to merge 1 commit intoetcd-io:mainfrom
nwnt:add-keys-only-option-mvcc
Open

Add --keys-only option for mvcc range#21612
nwnt wants to merge 1 commit intoetcd-io:mainfrom
nwnt:add-keys-only-option-mvcc

Conversation

@nwnt
Copy link
Copy Markdown
Member

@nwnt nwnt commented Apr 14, 2026

Part of #20386

We need the option so that the mvcc can perform --keys-only operation on the backend side.

Signed-off-by: Nont <nont@duck.com>
@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nwnt
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nwnt
Copy link
Copy Markdown
Member Author

nwnt commented Apr 14, 2026

cc @serathius

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.40%. Comparing base (9186f6a) to head (efad77f).
⚠️ Report is 36 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/mvcc/kv.go 40.00% <ø> (ø)

... and 39 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #21612   +/-   ##
=======================================
  Coverage   68.40%   68.40%           
=======================================
  Files         428      429    +1     
  Lines       35397    35391    -6     
=======================================
- Hits        24212    24210    -2     
+ Misses       9777     9774    -3     
+ Partials     1408     1407    -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9186f6a...efad77f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius
Copy link
Copy Markdown
Member

Any implementation plan?

@nwnt
Copy link
Copy Markdown
Member Author

nwnt commented Apr 15, 2026

Let me write that up and share with you in a google doc.

@serathius
Copy link
Copy Markdown
Member

Maybe let's talk first, the change is not as complicated to require a doc.

@k8s-ci-robot
Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants