fix(developers): add ISR revalidation to prevent stale hackathon events#18095
Open
nloureiro wants to merge 1 commit intoethereum:devfrom
Open
fix(developers): add ISR revalidation to prevent stale hackathon events#18095nloureiro wants to merge 1 commit intoethereum:devfrom
nloureiro wants to merge 1 commit intoethereum:devfrom
Conversation
The developers page is statically generated at build time, which means the hackathons section can show past events between deployments — events fetched from the Geode Labs Supabase API are correctly date-filtered in code, but only at build time. Adding `export const revalidate = 86400` tells Next.js to re-fetch and regenerate this page at most once every 24 hours (ISR), so events stay current without requiring a full deployment. Fixes ethereum#18086 Spotted via: weekly QA review (2026-04-27)
❌ Deploy Preview for ethereumorg failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18086
Problem
The /developers/ hackathons section shows events from a Geode Labs Supabase API. The filter logic in
fetchEvents.tscorrectly removes past events — but only at build time. Between deployments, old events linger in the static output, as happened with ETHGlobal Cannes (Apr 3–5) and ETHSilesia (Apr 16–19) appearing as upcoming after they had passed.Fix
Add Next.js ISR (
export const revalidate = 86400) to the developers page so it regenerates at most every 24 hours automatically, keeping the events list current without waiting for a full deployment.Changes
app/[locale]/developers/page.tsx— addexport const revalidate = 86400Why 24 hours
Events are typically announced days/weeks in advance so a 24 h window won't miss anything meaningful, while preventing the multi-week staleness seen now. This can be tuned down if needed.