Reorganize build to separate core functionality from future ROS2 development#24
Open
jjd9 wants to merge 9 commits intofacontidavide:mainfrom
Open
Reorganize build to separate core functionality from future ROS2 development#24jjd9 wants to merge 9 commits intofacontidavide:mainfrom
jjd9 wants to merge 9 commits intofacontidavide:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed here #23, this PR is the first of a small sequence of PR's intended to add rviz2 support for Bonxai.
This PR reorganizes the repo slightly to make it easier to add more ROS packages (E.g. msg/srv definitions, rviz plugin, etc...) to this repo without confusing usage for people who do not want to use the ROS2 parts of the repo.
Core functionality is moved to
BonxaisubdirectoryROS aspects are moved into
Bonxai_rossubdirectoryThe intended build approach is explained in the updates to the README.
This organization made sense to me, but I am happy to make changes if anyone has other ideas.
Thanks for your time! (-: