feat: add gzip handling to the hub_service#385
feat: add gzip handling to the hub_service#385Quazia wants to merge 3 commits intofarcasterxyz:mainfrom
hub_service#385Conversation
|
@Quazia is attempting to deploy a commit to the farcaster Team on Vercel. A member of the Team first needs to authorize it. |
| let grpc_shutdown_tx = shutdown_tx.clone(); | ||
| let hub_service = HubServiceServer::from_arc(service.clone()) | ||
| .accept_compressed(CompressionEncoding::Gzip) | ||
| .send_compressed(CompressionEncoding::Gzip); |
There was a problem hiding this comment.
Is this always or only if the header is present in the request? Just want to make sure it won't break existing clients.
There was a problem hiding this comment.
I'm 95% sure that it accepts it, but it doesn't require it.
There was a problem hiding this comment.
Yep - accepts but doesn't require it.
| serde_json = "1.0" | ||
| sha2 = "0.10.6" | ||
| tonic = "0.12.3" | ||
| tonic = { version = "0.12.3", features = ["gzip"] } |
There was a problem hiding this comment.
I think there were some issues upgrading tonic-build. Worth a shot if build passes, but if it requires a bunch of patches, probably not worth it.
There was a problem hiding this comment.
It requires a fair number of patches but still would be worth picking up at some point.
3 participants
Closses #373
I don't know if we want to add a test for this - not sure how we'd go about it since we probably don't want to test
main.rsdirectly.Also noticed that the
tonicandtonic-buildversions are quite different. Worth updating them to be consistent or is there a reason for the oldertonic-buildversion?