[V2] Add Trigger service and Scheler#7163
Draft
machichima wants to merge 13 commits intoflyteorg:v2from
Draft
Conversation
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
machichima
commented
Apr 7, 2026
| } | ||
|
|
||
| // CreateRun creates a new run (root action with parent_action_name = null) | ||
| func (r *actionRepo) CreateRun(ctx context.Context, req *workflow.CreateRunRequest, inputUri, runOutputBase string) (*models.Run, error) { |
Member
Author
There was a problem hiding this comment.
Remove this and rely on CreateAction logic. Also move the part of forming the task spec to run_service.go
Signed-off-by: machichima <nary12321@gmail.com>
…atchAction Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
Add Trigger functionality for task scheduling
What changes were proposed in this pull request?
Note:
ListRunsAPI does not deal with filters correctly, therefor when viewing runs for a task / trigger, it will include irrelevant tasks. We will deal with this in a follow-up PR.How was this patch tested?
Run on sandbox locally.
List Triggers
Cron string
Run sandbox locally and deploy trigger example task:
Ensure trigger tasks are being created and catch up works (after sandbox restart, should catch up all missed schedules)
Fixed rate
Create fixed rate example:
Deploy example with:
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main