Open
Conversation
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
pingsutw
approved these changes
Apr 13, 2026
Comment on lines
+1
to
+19
| package logs | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| "connectrpc.com/connect" | ||
| "github.com/samber/lo" | ||
|
|
||
| "github.com/flyteorg/flyte/v2/gen/go/flyteidl2/core" | ||
| "github.com/flyteorg/flyte/v2/gen/go/flyteidl2/workflow" | ||
| ) | ||
|
|
||
| // LogStreamer abstracts log fetching from different backends. | ||
| type LogStreamer interface { | ||
| TailLogs(ctx context.Context, logContext *core.LogContext, stream *connect.ServerStream[workflow.TailLogsResponse]) error | ||
| } | ||
|
|
||
| // GetPrimaryPodAndContainer finds the primary pod and container from a LogContext. |
Member
There was a problem hiding this comment.
nit: could we move this file to dataproxy/ instead of adding a new folder at the project root
Contributor
Author
There was a problem hiding this comment.
done but now run logs service depends on logs service - is that okay? eventually we can rip out the run logs service implementation once the sdk changes are in, so i guess it's temporary
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
pingsutw
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And add a
GetActionLogContextto fetch log context from RunsServiceWhy are the changes needed?
Required to reduce dataflow in a secure environment.
What changes were proposed in this pull request?
See PR title
How was this patch tested?
Ran the demo cluster locally. Tested with flyte-sdk and this script
Verified output worked fine
Labels
Please add one or more of the following labels to categorize your PR:
This is important to improve the readability of release notes.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
main