Add Android adaptive icon support#115
Merged
andydotxyz merged 8 commits intofyne-io:mainfrom Feb 16, 2026
Merged
Conversation
This code is becoming legacy and will be removed in a future version
Member
Author
|
You can see usage at andydotxyz/fynepet@695c81a |
andydotxyz
force-pushed
the
fix/adaptiveicon
branch
from
b07ea46 to
c67a4c4
Compare
Member
Author
|
Showing the impact: 
|
sdassow
reviewed
Feb 13, 2026
| } | ||
|
|
||
| // If monochrome provided, create v33 resources with monochrome support | ||
| if hasMonochrome { |
Contributor
There was a problem hiding this comment.
Minor nit: inverting the check would allow to return nil early and have less indented code after.
sdassow
reviewed
Feb 13, 2026
| defer r.Close() | ||
|
|
||
| for _, f := range r.File { | ||
| if f.Name == fileName { |
Contributor
There was a problem hiding this comment.
Similar minor nit, inverting the check could lead to less nested code.
sdassow
reviewed
Feb 13, 2026
| monochrome = filepath.Join(dir, "Icon-monochrome.png") | ||
| } | ||
|
|
||
| if util.Exists(foreground) { |
Contributor
There was a problem hiding this comment.
Same minor nit pick again.
Member
Author
|
Good nits @sdassow - updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an optional extra, if present you need to have a more recent Android SDK to compile (but still 9 years old ;) ).
Create files
icon-foreground.png,Icon-background.png(optional) andIcon-monospace.png(optional) to get picked up automatically. Or you can use the new[AdaptiveIcon]section withForeground,BackgroundandMonospace.Fixes fyne-io/fyne#1270
Future work (other PRs, later)