Make sure that CGO is not enabled when building in WASM mode#121
Merged
andydotxyz merged 2 commits intofyne-io:mainfrom Mar 9, 2026
Merged
Make sure that CGO is not enabled when building in WASM mode#121andydotxyz merged 2 commits intofyne-io:mainfrom
andydotxyz merged 2 commits intofyne-io:mainfrom
Conversation
andydotxyz
requested changes
Mar 5, 2026
Member
andydotxyz
left a comment
andydotxyz
left a comment
There was a problem hiding this comment.
Thank you for this. Apologies for my change request, but it helps to keep things neater for future maintenance.
typenoob
force-pushed
the
wasm-with-cgo-enabled
branch
from
7c51fe2 to
1366d58
Compare
Contributor
Author
|
Done @andydotxyz |
Member
Nice one. I think you didn't run tests though - looks like we need to correct the checks to include this new env |
Contributor
Author
|
Sorry I missed that. I think it's all good now. @andydotxyz |
andydotxyz
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #120
Pretty simple change.