Return opaque iterator for nearest neighbor searches#98
Draft
kylebarron wants to merge 2 commits intomainfrom
Draft
Return opaque iterator for nearest neighbor searches#98kylebarron wants to merge 2 commits intomainfrom
kylebarron wants to merge 2 commits intomainfrom
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice to finish this but also ensure this isn't a performance regression. It feels like the iterator has to repeat some steps that the existing method doesn't.
Perhaps it would be better to introduce a state machine, so that the iterator can check between an enum of states like "search child nodes, search queue, etc".
But overall I want to get the main library released, so this will wait for the next version.