fix(mcp): accept scalar group_ids in read tools#1354
Open
Ker102 wants to merge 1 commit intogetzep:mainfrom
Open
fix(mcp): accept scalar group_ids in read tools#1354Ker102 wants to merge 1 commit intogetzep:mainfrom
Ker102 wants to merge 1 commit intogetzep:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the MCP read tools a little more forgiving in the single-workspace case.
Right now they only accept
group_idsas a list, which means a call likegroup_ids="ideadb"fails validation even though the meaning is obvious. That’s easy enough to work around, but some MCP clients naturally surface the scalar form for simple inputs, so it ends up being a real integration problem.This change lets the server accept either a string or a list and normalizes the string form internally. Existing list-based calls keep working as-is.
I added focused tests for
search_nodes,search_memory_facts,get_episodes, andclear_graph.Tested with:
uv run --project mcp_server pytest tests/test_group_id_normalization.pyuv run --project mcp_server ruff check src/graphiti_mcp_server.py tests/test_group_id_normalization.py