fix: handle IPv6 brackets and port in X-Forwarded-For parsing#4584
Open
guoyangzhen wants to merge 1 commit intogin-gonic:masterfrom
Open
fix: handle IPv6 brackets and port in X-Forwarded-For parsing#4584guoyangzhen wants to merge 1 commit intogin-gonic:masterfrom
guoyangzhen wants to merge 1 commit intogin-gonic:masterfrom
Conversation
The validateHeader function failed to parse X-Forwarded-For values with: - IPv6 addresses in brackets: [240e:318:2f4a:de56::240] - Port numbers: 192.168.8.39:38792 - Both: [240e:318:2f4a:de56::240]:38792 Use net.SplitHostPort to properly handle all formats, falling back to bracket stripping for bare bracketed IPv6 addresses. Fixes gin-gonic#4572
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4584 +/- ##
==========================================
- Coverage 99.21% 98.34% -0.87%
==========================================
Files 42 48 +6
Lines 3182 3143 -39
==========================================
- Hits 3157 3091 -66
- Misses 17 41 +24
- Partials 8 11 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4572 —
validateHeaderfails to parse X-Forwarded-For values with IPv6 brackets or port numbers.Problem
Some reverse proxies (IIS, cloud load balancers) send X-Forwarded-For with:
[240e:318:2f4a:de56::240]192.168.8.39:38792[240e:318:2f4a:de56::240]:38792net.ParseIPreturnsnilfor all of these, causingClientIP()to fall back toRemoteAddr.Fix
Use
net.SplitHostPortto properly strip brackets and port, with fallback to manual bracket removal for bare bracketed IPv6.Test Cases
Fixes #4572