Skip to content

Translate Qt sessions to Jupyter sessions#459

Draft
astrofrog wants to merge 6 commits intoglue-viz:mainfrom
astrofrog:restore-session
Draft

Translate Qt sessions to Jupyter sessions#459
astrofrog wants to merge 6 commits intoglue-viz:mainfrom
astrofrog:restore-session

Conversation

@astrofrog
Copy link
Copy Markdown
Member

Work in progress, seems to work for basic plot types but need to work on 3D viewers and WWT. Also need to decide on an API and a way to select which widgets to use (bqplot vs matplotlib, vispy vs ipyvolume)

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 12, 2024

Codecov Report

❌ Patch coverage is 69.86301% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.84%. Comparing base (54499a8) to head (6c8ad30).
⚠️ Report is 198 commits behind head on main.

Files with missing lines Patch % Lines
glue_jupyter/session.py 36.84% 12 Missing ⚠️
glue_jupyter/app.py 62.50% 9 Missing ⚠️
glue_jupyter/tests/test_session.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   86.07%   85.84%   -0.24%     
==========================================
  Files          90       92       +2     
  Lines        5242     5312      +70     
==========================================
+ Hits         4512     4560      +48     
- Misses        730      752      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@astrofrog
Copy link
Copy Markdown
Member Author

Note to self, if glue-jupyter is installed it will break session loading in glue-qt as the plugin will always apply the patches. I need to find a way of conditionally applying it just when loaded from Jupyter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant