Translate Qt sessions to Jupyter sessions#459
Draft
astrofrog wants to merge 6 commits intoglue-viz:mainfrom
Draft
Translate Qt sessions to Jupyter sessions#459astrofrog wants to merge 6 commits intoglue-viz:mainfrom
astrofrog wants to merge 6 commits intoglue-viz:mainfrom
Conversation
…d test and fix translation for basic plots
…more tweaks to session translation
b7e5392 to
6c8ad30
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
- Coverage 86.07% 85.84% -0.24%
==========================================
Files 90 92 +2
Lines 5242 5312 +70
==========================================
+ Hits 4512 4560 +48
- Misses 730 752 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Note to self, if glue-jupyter is installed it will break session loading in glue-qt as the plugin will always apply the patches. I need to find a way of conditionally applying it just when loaded from Jupyter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress, seems to work for basic plot types but need to work on 3D viewers and WWT. Also need to decide on an API and a way to select which widgets to use (bqplot vs matplotlib, vispy vs ipyvolume)