feat: ipyvuetify 3 compatibility#519
Conversation
astrofrog
left a comment
astrofrog
left a comment
There was a problem hiding this comment.
Thanks! Just a comment below. I think we should probably also hold back from merging this until ipyvue 3.0.0 final is released?
glue_jupyter/table/table.vue
Outdated
| ...this.options, | ||
| itemsPerPage: pageSize, | ||
| totalItems: this.total_length, | ||
| }; |
There was a problem hiding this comment.
Just curious, is this adding a new feature or is it that what we had before is no longer possible by default?
There was a problem hiding this comment.
No new feature, the prop structure change. This was a quick AI implementation I didn't check yet and was a bit over complicated.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
=======================================
Coverage 82.86% 82.86%
=======================================
Files 91 91
Lines 5638 5638
=======================================
Hits 4672 4672
Misses 966 966 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Should this pass tests with the ipyvuetify 3 alpha? The KeyError on |
mariobuikhuizen
force-pushed
the
vue3
branch
2 times, most recently
from
e8f234a to
418e88f
Compare
3 participants
Pull Request Template
Description
Adds ipyvuetify 3 compatibility