Update ipyvolume viewer to use reference data#520
Update ipyvolume viewer to use reference data#520Carifio24 wants to merge 19 commits intoglue-viz:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #520 +/- ##
==========================================
- Coverage 79.11% 78.20% -0.91%
==========================================
Files 96 97 +1
Lines 6013 6001 -12
==========================================
- Hits 4757 4693 -64
- Misses 1256 1308 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I ended up using a small Python wrapper around the float-field widget for setting vmin and vmax instead. This also has the advantage of letting the user set the bounds outside of the data range (maybe someone would want this?) and allowing them to set at whatever precision they need. |
|
@Carifio24 - just to check, is this ready for review/testing? |
|
@astrofrog It is, yes |
| import traitlets | ||
|
|
||
|
|
||
| class GlueFloatField(v.VuetifyTemplate): |
There was a problem hiding this comment.
This currently introduces a vuetify widget in the middle of the ipywidgets options - I think it would be best to either go with an ipywidget or go all in on vuetify in the 3D viewers. If we do the latter, then the existing glue-float-field solves this issue?
There was a problem hiding this comment.
Agreed that mixing the widget types is not ideal. I would vote for going all on Vuetify, in which case yeah the existing glue-float-field would work perfectly.
I can update the 3D viewer widget in this PR. I'm thinking makes sense to wait for #529, then rebase this so that any Vuetify template updates are using the new echo scheme, does that seem reasonable?
…own into viewer options widget.
…ted wrt viewer bounds.
918a5d8 to
b7961c1
Compare
|
Rebased on top of main to pick up the changes from #529. Marking this as a draft until I finish the relevant 3D viewer widget updates. |
f6c53b9 to
eff2495
Compare
|
@astrofrog I've updated the 3D viewer widgets to use Vuetify now. I'm having one issue with the 3D scatter widget - I keep getting a warning because |
456fb3c to
fcd5f32
Compare
This PR updates the ipyvolume viewer to use the same viewer-level resolution/fixed resolution buffer scheme used in e.g.
glue-vispy-viewers.The one thing that I'm having trouble with here is the float sliders that control vmin/vmax for each layer. It looks like they should be set to track the min/max data from the layer state, but they keep getting reset to 0/1.