Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2288 +/- ##
==========================================
- Coverage 88.13% 87.97% -0.16%
==========================================
Files 247 247
Lines 23292 23360 +68
==========================================
+ Hits 20528 20551 +23
- Misses 2764 2809 +45
Continue to review full report at Codecov.
|
Member
|
@jfoster17 - are you still interested in pushing this forward? If so, this will need a rebase - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This is a work-in-progress towards providing the ability to automatically create subsets for categorical attributes (as suggested in #1151 and #2004). Ultimately, I envision this might expand to allow subsetting on up to two categoricals at once, and for this reason I have added it as a new dialog option instead of modifying the existing facet_subset. Some items that remain: