Skip to content

chore(deps): upgrade lestrrat-go/jwx lib to v4#1449

Open
ecrupper wants to merge 4 commits intomainfrom
chore/deps/upgrade-jwx-v4
Open

chore(deps): upgrade lestrrat-go/jwx lib to v4#1449
ecrupper wants to merge 4 commits intomainfrom
chore/deps/upgrade-jwx-v4

Conversation

@ecrupper
Copy link
Copy Markdown
Contributor

@ecrupper ecrupper commented May 4, 2026

A couple breaking changes: GOEXPERIMENT=jsonv2 is required, and the Import functions are now generic.

@ecrupper ecrupper requested a review from a team as a code owner May 4, 2026 15:05
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.03%. Comparing base (290c7b0) to head (dc49ad2).

Files with missing lines Patch % Lines
internal/token/generate_rsa.go 0.00% 16 Missing ⚠️
database/testutils/api_resources.go 0.00% 7 Missing ⚠️

❌ Your project check has failed because the head coverage (58.03%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1449      +/-   ##
==========================================
+ Coverage   58.01%   58.03%   +0.01%     
==========================================
  Files         663      663              
  Lines       25588    25580       -8     
==========================================
  Hits        14845    14845              
+ Misses      10043    10035       -8     
  Partials      700      700              
Files with missing lines Coverage Δ
database/jwk/create.go 84.61% <ø> (ø)
database/jwk/get.go 100.00% <ø> (ø)
database/jwk/list.go 76.47% <ø> (ø)
database/testutils/mock_args.go 0.00% <ø> (ø)
database/types/jwk.go 77.77% <ø> (ø)
mock/server/authentication.go 0.00% <ø> (ø)
database/testutils/api_resources.go 0.00% <0.00%> (ø)
internal/token/generate_rsa.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wass3rw3rk
Copy link
Copy Markdown
Member

i'd prefer to wait until json v2 is not hidden behind experimental flag (the proposal is still marked as "under review" here json/v2 working group). it does seem like it is close and i saw chatter for this to be GA in Go 1.27. for now, it seems this package supports both v3 and v4 (saw them cut a release for both on the same day), so i would propose to slot this in for v29 or beyond even (whenever it drops as GA). thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants