You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.03%. Comparing base (290c7b0) to head (dc49ad2).
❌ Your project check has failed because the head coverage (58.03%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.
i'd prefer to wait until json v2 is not hidden behind experimental flag (the proposal is still marked as "under review" here json/v2 working group). it does seem like it is close and i saw chatter for this to be GA in Go 1.27. for now, it seems this package supports both v3 and v4 (saw them cut a release for both on the same day), so i would propose to slot this in for v29 or beyond even (whenever it drops as GA). thoughts?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple breaking changes:
GOEXPERIMENT=jsonv2is required, and theImportfunctions are now generic.