GD-1071: Fix context menu shortcuts broken after settings dialog change#1081
Merged
MikeSchulze merged 2 commits intomasterfrom Mar 18, 2026
Merged
GD-1071: Fix context menu shortcuts broken after settings dialog change#1081MikeSchulze merged 2 commits intomasterfrom
MikeSchulze merged 2 commits intomasterfrom
Conversation
# Why Shortcuts registered in `_init()` captured the shortcut object at plugin load time. Changes made via the GdUnit settings dialog were not reflected, leaving the context menus broken or using stale keybindings. # What - Move `add_menu_shortcut()` from `_init()` into `_popup_menu()`, so shortcuts are resolved fresh on every popup - Filter selected paths to test suites only in the file system handler before building the menu; skip extending the menu if none qualify - Guard `GdUnitThreadContext.terminate()` against a null execution context to prevent a crash if called after `dispose()`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Shortcuts registered in
_init()captured the shortcut object at plugin load time. Changes made via the GdUnit settings dialog were not reflected, leaving the context menus broken or using stale keybindings.What
add_menu_shortcut()from_init()into_popup_menu(), so shortcuts are resolved fresh on every popupGdUnitThreadContext.terminate()against a null execution context to prevent a crash if called afterdispose()