ui: Fix several issues with counter tracks#5449
Merged
stevegolton merged 2 commits intomainfrom Apr 15, 2026
Merged
Conversation
🎨 Perfetto UI Builds
|
- Push all query state through the QuerySlot and remove invalidiate() - Fix bug where in min-max and log mode the bottom of the graph would be offscreen. - Print the top and bottom of the y axis as labels rather than just the range. - Remove the zero y axis dashed line. - Improved number formatting for labels and y-axis ticks.
stevegolton
force-pushed
the
dev/sg/countertrack-refactor
branch
from
85d6177 to
d00ca35
Compare
stevegolton
changed the title
LalitMaganti
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
min-maxandlogmodes renders the bottom of the graph offscreen.BaseCounterTrack(& rename toCounterTrackto mirror SliceTrack).createQueryCounterTrackasCounterTracknow does everything it used to do.