Skip to content

Refactor: Enforce explicit problem type validation in config loader #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RinZ27 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor: Enforce explicit problem type validation in config loader #973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions llm_studio/src/utils/config_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,11 @@ def convert_nested_dictionary_to_cfg_base(
Inverse operation of convert_cfg_base_to_nested_dictionary
"""
problem_type = cfg_dict["problem_type"]
allowed_types = GENERATION_PROBLEM_TYPES + NON_GENERATION_PROBLEM_TYPES + ["text_sequence_to_sequence_modeling"]

if problem_type not in allowed_types:
raise NotImplementedError(f"Problem Type {problem_type} not implemented or allowed")

module_name = f"llm_studio.python_configs.{problem_type}_config"
try:
module = importlib.import_module(module_name)
Expand Down