defineDebugInfoPackage: change first argument to basePackageSuffix#349
defineDebugInfoPackage: change first argument to basePackageSuffix#349jmairboeck wants to merge 2 commits intohaikuports:masterfrom
Conversation
1e2d8d2 to
832d615
Compare
|
I changed the |
This is a first test and to demonstrate haikuports/haikuporter#349. Note: if this is going to be merged, all current usages of defineDebugInfoPackage need to be changed like this. This should be doable with a mass replacement. No revision bump is needed because the output doesn't change, only the input syntax.
|
Another question: should this handle inherited attributes (like SUMMARY, DESCRIPTION etc.) to automatically "inherit" them from the (non-default) base package, if they have been overridden for that? (I guess this can get pretty complex if we really want to go that far ...) |
I was fighting with this the other day, thinking about adding a SUMMARY for a doc package, haikuporter automatically adds a "documentation" suffix to the package just like it's done for the "development" suffix, so I guess it should follow that order (should check how this is done for tools packages?). |
This is another, more complex example of haikuports/haikuporter#349 to also split the debuginfo package.
I think this is easier to be handled in the recipes. Let's say: if you override these variables for the debuginfo base package, you also have to do it for the debuginfo package manually for consistency. I'll add that to the glib recipe in the example PR. |
This is another, more complex example of haikuports/haikuporter#349 to also split the debuginfo package.
This requires haikuports/haikuporter#349.
This requires haikuports/haikuporter#349.
This requires haikuports/haikuporter#349.
d700ac2 to
e78d1b7
Compare
This allows defining multiple debuginfo packages by not hard-coding the used packageSuffix for the debuginfo package any more but deriving it from the basePackageSuffix instead. Note: This is a breaking change! All invocations of defineDebugInfoPackage in haikuports must be changed. The default case to define the main debuginfo package is to use an empty string (i.e. "") as the first argument now. To define a debuginfo package for a subpackage, use its package suffix instead (similar to packageEntries and getPackagePrefix). Also adds support for PACKAGE_NAME and PACKAGE_VERSION overrides, both for the referenced base package and the debuginfo package itself. In both cases, they must be declared before defineDebugInfoPackage is called. Fixes haikuports#348. Add a missing line continuation to the usage error message.
for non-main debuginfo packages.
e78d1b7 to
dc12206
Compare
|
I now also fixed the missing line continuation in the usage error message. |
|
For reference: this should apply the necessary transformation for all current usages of defineDebugInfoPackage in haikuports: if/when this is applied and deployed. |
This allows defining multiple debuginfo packages by not hard-coding the used packageSuffix for the debuginfo package any more but deriving it from the basePackageSuffix instead.
Note: This is a breaking change! All invocations of defineDebugInfoPackage in haikuports must be changed. The default case to define the main debuginfo package is to use an empty string (i.e. "") as the first argument now. To define a debuginfo package for a subpackage, use its package suffix instead (similar to packageEntries and getPackagePrefix).
Also adds support for PACKAGE_NAME and PACKAGE_VERSION overrides, both for the referenced base package and the debuginfo package itself. In both cases, they must be declared before defineDebugInfoPackage is called.
Fixes #348.
Question: should the
debugInfoSuffixalso be changed for subpackages? (i.e. the base package name and version that is added to debug info file names)