Mark builders lost after many transient failures and reconnect handling fixes#351
Merged
pulkomandy merged 4 commits intohaikuports:masterfrom Nov 27, 2025
Merged
Conversation
If the state remains AVAILABLE, no reconnect will be attempted in the next run, leading to the reuse of a closed connection.
This mostly reverts ca6c9a3. The change tried to "reconnect" SFTP on each command. As it reused the existing SSH connection, this merely spawned a new internal SFTP client on the remote side and wouldn't actually reestablish any connections. The new code lead to only partial handling of exceptions, producing somewhat cryptic errors instead of showing the underlying issue. The logging changes from that commit are left intact. Also clean up two unused methods.
The RECONNECT state does not need further handling, as the reconnection happens automatically. Having the builder removed from the active builder list would spuriously lead to the "all builders lost" state even when reconnects should have happened.
Member
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After 10 consecutive transient failures, mark the builder lost. This prevents errors during build setup to repeat indefinitely. Also fix the original issue that triggered the change above, a symptom seen there and a related reconnect handling fix.