Skip to content

Vmc gi version tag#46589

Merged
jar-b merged 21 commits intohashicorp:mainfrom
oracle-community:vmc-gi-version-tag
May 5, 2026
Merged

Vmc gi version tag#46589
jar-b merged 21 commits intohashicorp:mainfrom
oracle-community:vmc-gi-version-tag

Conversation

@ab-cs13
Copy link
Copy Markdown
Contributor

@ab-cs13 ab-cs13 commented Feb 20, 2026

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

NA

Description

gi_version is a mandatory field when creating a cloud_vm_cluster. The underlying API accepts only the major gi_version values 19.0.0.0 or 23.0.0.0, or a value sourced from the list-gi-versions data source.

After creation, the cloud-vm-cluster read operation returns the full GI version (for example, 23.1.4.0.5). In Terraform, this is stored in the computed_gi_version attribute. We then derive the major GI version by parsing the major portion (e.g., 23.1.4.0.5 → 23.0.0.0).

Recently, the underlying API introduced a change that is not compatible with the current parsing logic. Specifically, for the major version 26.0.0.0, the read operation returns 23.1.2.5, which causes Terraform to fail.

This PR introduces a tag-based approach to preserve the user-provided major gi_version input.

References

Output from Acceptance Testing

Screenshot 2026-02-20 at 13 43 01

@ab-cs13 ab-cs13 requested a review from a team as a code owner February 20, 2026 16:08
@github-actions
Copy link
Copy Markdown
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 20, 2026

⚠️ Our automation has detected the following potential issues with your pull request


❌ Maintainer Edit Permissions (Click to expand)

At times, our maintainers need to make direct edits to pull requests in order to prepare it to be merged. At the time of opening this pull request, your settings do not allow maintainers to make such edits. If possible, update your settings as described in the following document. If your fork is owned by an organization that limits your ability to make this change, please let us know.

Please see the GitHub documentation on allowing changes to a pull request branch created from a fork for additional details.

@github-actions github-actions Bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/odb Issues and PRs that pertain to the odb service. size/M Managed by automation to categorize the size of a PR. labels Feb 20, 2026
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Feb 25, 2026
Comment thread internal/service/odb/cloud_vm_cluster.go Outdated
Comment thread internal/service/odb/cloud_vm_cluster.go
Comment thread .changelog/46589.txt Outdated
@jar-b jar-b assigned jar-b and unassigned jar-b Apr 29, 2026
@github-actions github-actions Bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 29, 2026
ab-cs13 and others added 4 commits April 30, 2026 15:42
@github-actions github-actions Bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels May 1, 2026
@github-actions github-actions Bot added the documentation Introduces or discusses updates to documentation. label May 1, 2026
Comment thread website/docs/r/odb_cloud_vm_cluster.html.markdown
Comment thread internal/service/odb/cloud_vm_cluster_test.go Outdated
Comment thread internal/service/odb/cloud_vm_cluster_test.go
Comment thread website/docs/r/odb_cloud_vm_cluster.html.markdown Outdated
@github-actions github-actions Bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels May 4, 2026
Comment thread website/docs/r/odb_cloud_vm_cluster.html.markdown Outdated
Comment thread website/docs/r/odb_cloud_vm_cluster.html.markdown Outdated
Comment thread website/docs/r/odb_cloud_vm_cluster.html.markdown Outdated
Comment thread website/docs/r/odb_cloud_vm_cluster.html.markdown Outdated
ab-cs13 and others added 4 commits May 4, 2026 20:22
Co-authored-by: Jared Baker <jar-b@users.noreply.github.com>
Co-authored-by: Jared Baker <jar-b@users.noreply.github.com>
Co-authored-by: Jared Baker <jar-b@users.noreply.github.com>
Co-authored-by: Jared Baker <jar-b@users.noreply.github.com>
Copy link
Copy Markdown
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jar-b
Copy link
Copy Markdown
Member

jar-b commented May 5, 2026

Thanks for your contribution, @ab-cs13! 👍

@jar-b jar-b merged commit 6c7a340 into hashicorp:main May 5, 2026
49 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions Bot added this to the v6.44.0 milestone May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/odb Issues and PRs that pertain to the odb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants