New Resource: aws_datazone_policy_grant#47050
Open
aamir296 wants to merge 4 commits intohashicorp:mainfrom
Open
New Resource: aws_datazone_policy_grant#47050aamir296 wants to merge 4 commits intohashicorp:mainfrom
aamir296 wants to merge 4 commits intohashicorp:mainfrom
Conversation
Implements the aws_datazone_policy_grant resource for managing DataZone policy grants via AddPolicyGrant/RemovePolicyGrant/ListPolicyGrants APIs. Closes hashicorp#46764
Contributor
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
Contributor
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
- Add @testing annotations for importStateIdAttributes to fix identity test import (ImportCommandWithID was failing with "id-attribute-not-set") - Add TestAccDataZonePolicyGrant_projectPrincipal test validating project principal with CREATE_GLOSSARY policy (CREATE_PROJECT was rejected by API) - Update documentation example to use validated CREATE_GLOSSARY combination - Add 11 unit tests for flatten functions and import ID parser - Regenerate identity tests and test data templates
Per maintainer convention, move aws_datazone_policy_grant to the top of the generated test template, followed by its dependencies. Regenerate test data files accordingly.
Author
|
Hi @justinretzolk , just checking in on this PR. Could you help get this queued for review, or is there anything I can update to help move it forward? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
aws_datazone_policy_grantresource for managing DataZone policy grants via AddPolicyGrant/RemovePolicyGrant/ListPolicyGrants APIs. Closes #46764Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
No changes to security controls. This PR adds a new resource that calls existing AWS DataZone APIs (AddPolicyGrant, RemovePolicyGrant, ListPolicyGrants).
Description
Adds the
aws_datazone_policy_grantresource to manage AWS DataZone policy grants.New Resource
aws_datazone_policy_grantAPI Operations
AddPolicyGrantListPolicyGrants(paginated, match bygrantId)RemovePolicyGrantFeatures
domain_identifier,entity_type,entity_identifier,policy_type,grant_id)framework.WithRegionModelFollow-up
A List Resource for
aws_datazone_policy_grantwill be submitted in a separate follow-up PR once this resource's Resource Identity is merged, as per the List Resource prerequisites.Relations
Closes #46764
References
Output from Unit Testing
Output from Acceptance Testing