Skip to content

fix(grafana): allow empty lists in network_access_control#47379

Closed
taraspos wants to merge 2 commits intohashicorp:mainfrom
taraspos:patch-1
Closed

fix(grafana): allow empty lists in network_access_control#47379
taraspos wants to merge 2 commits intohashicorp:mainfrom
taraspos:patch-1

Conversation

@taraspos
Copy link
Copy Markdown

@taraspos taraspos commented Apr 9, 2026

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Allow passing empty lists in network_access_control, because both arguments are required by the upstream API, but empty list values are valid configurations.

Relations

Closes #45908

@taraspos taraspos requested a review from a team as a code owner April 9, 2026 14:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@dosubot dosubot Bot added the bug Addresses a defect in current functionality. label Apr 9, 2026
@github-actions github-actions Bot added needs-triage Waiting for first response or review from a maintainer. service/grafana Issues and PRs that pertain to the grafana service. size/XS Managed by automation to categorize the size of a PR. labels Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Addresses a defect in current functionality. service/grafana Issues and PRs that pertain to the grafana service. size/XS Managed by automation to categorize the size of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS Managed Grafana - Network Access Control

2 participants