Skip to content

Provider: Removes run-time validation for Framework-based resource types#47750

Merged
gdavison merged 10 commits intomainfrom
td-no-validate-model-at-runtime
May 5, 2026
Merged

Provider: Removes run-time validation for Framework-based resource types#47750
gdavison merged 10 commits intomainfrom
td-no-validate-model-at-runtime

Conversation

@gdavison
Copy link
Copy Markdown
Contributor

@gdavison gdavison commented May 4, 2026

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Removes run-time validation for Framework-based resource types and adds validation step to Makefile directives.

Will reduce memory usage when initializing the provider. Only the schemas for resource types that are used in the configuration should be allocated.

Relates: #47003

Iteration Count Time per Operation Bytes per Operation Allocations per Operation
Before 58 17366403 ns/op 15072518 B/op 167863 allocs/op
After 6097 185166 ns/op 244381 B/op 2420 allocs/op

@gdavison gdavison requested a review from a team as a code owner May 4, 2026 19:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/XL Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels May 4, 2026
Comment thread GNUmakefile
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus add new target to docs/makefile-cheat-sheet.md.

Comment thread GNUmakefile Outdated
@github-actions github-actions Bot added the documentation Introduces or discusses updates to documentation. label May 5, 2026
Copy link
Copy Markdown
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gdavison gdavison merged commit 10cdde3 into main May 5, 2026
63 checks passed
@gdavison gdavison deleted the td-no-validate-model-at-runtime branch May 5, 2026 21:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions Bot added this to the v6.44.0 milestone May 5, 2026
terraform-aws-provider Bot pushed a commit that referenced this pull request May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants