Skip to content

generate/identitytests: Correct PlanCheck for single identity attribute when plannableImportAction="Replace"#47768

Merged
ewbankkit merged 1 commit intomainfrom
b-generate/identitytests-PlannableResourceAction.Replace
May 5, 2026
Merged

generate/identitytests: Correct PlanCheck for single identity attribute when plannableImportAction="Replace"#47768
ewbankkit merged 1 commit intomainfrom
b-generate/identitytests-PlannableResourceAction.Replace

Conversation

@ewbankkit
Copy link
Copy Markdown
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Noticed while adding RI to Timestream InfluxDB (#47052). If an import step results in resource replacement then the identity attribute will plan to Unknown.
Restricted to the single identity attribute case as for many multi-attribute parameterized identity resource, not all identity attributes will be unknown.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions Bot added generators Relates to code generators. size/XS Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels May 5, 2026
@ewbankkit ewbankkit marked this pull request as ready for review May 5, 2026 17:19
@ewbankkit ewbankkit requested a review from a team as a code owner May 5, 2026 17:19
@dosubot dosubot Bot added the bug Addresses a defect in current functionality. label May 5, 2026
Copy link
Copy Markdown
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit 00eec28 into main May 5, 2026
63 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions Bot added this to the v6.44.0 milestone May 5, 2026
@ewbankkit ewbankkit deleted the b-generate/identitytests-PlannableResourceAction.Replace branch May 5, 2026 17:50
ewbankkit added a commit to akostadinov-nasuni/terraform-provider-aws that referenced this pull request May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Addresses a defect in current functionality. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/XS Managed by automation to categorize the size of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants